feat: Use new Android SDK #749
Conversation
android/build.gradle
Outdated
| @@ -13,20 +13,26 @@ android { | |||
| } | |||
|
|
|||
| defaultConfig { | |||
| minSdkVersion safeExtGet('minSdkVersion', 16) | |||
| minSdkVersion safeExtGet('minSdkVersion', 21) | |||
There was a problem hiding this comment.
We're aiming API 18 on sentry-android-ndk. For sentry-android only it's API 14
There was a problem hiding this comment.
you may keep 16, and do this on manifest -> https://github.com/getsentry/sentry-android/blob/fd6413b92ed97efdecccc1fa6d8abef27fb1c816/sentry-sample/src/main/AndroidManifest.xml#L7
so you support non-ndk from 16 to 20 and with ndk support from 21 on
There was a problem hiding this comment.
no changes needed on manifest, minSdkVersion=16 just works :)
| } | ||
| }, | ||
|
|
||
| platform: Platform.OS |
There was a problem hiding this comment.
What is this platform used for?
# Conflicts: # android/src/main/java/io/sentry/RNSentryModule.java
fix: Native crash handling on android ref: Remove extraUpdated
|
Would this possibly fix the crashes on RN >= 60 mentioned here: https://github.com/getsentry/sentry-react-native/blob/feat/new-android-sdk/src/js/sdk.ts#L47 ? |
|
@wodCZ Done! |
Fixes #742
Fixes #734
Fixes #713
Fixes #695
Fixes #677
Fixes #674
Fixes #667
Fixes #656
Fixes #647
Fixes #623
Fixes #748
Fixes #649
Fixes #757
Fixes #685